On Thu, May 21, 2026 at 05:49:51PM -0700, Andrew Morton wrote:
>On Wed, 20 May 2026 09:38:24 +0000 Wei Yang <[email protected]> wrote:
>>
>> Subject: [PATCH] selftests/mm: close fd on write error
>>
>
>selftest/mm is a big place nowadays. I'll rewrite this to
>"selftests/mm/split_huge_page_test.c: ...".
>
Thanks, will do similar in future work.
>> >I asked AI and it points to another problem:
>> >
>> >for (i = 0; i < nr_thps; i++) {
>> > if (is_backed_by_folio(page_area + i * pagesize, 0,
>> > pagemap_fd, kpageflags_fd))
>> > continue;
>> > ksft_test_result_fail("THP %zu not split\n", i);
>> >}
>> >
>> >ksft_test_result_pass("Split PTE-mapped huge pages successful\n");
>> >
>> >"If one THP is not split, it prints FAIL, but then falls through and also
>> >prints PASS.
>> >
>> >It should probably jump to out after the failure".
>> >
>
>https://sashiko.dev/#/patchset/[email protected]
>doesn't say this?
>
I took a look into the above link, but not see any comment.
Not sure I got it clearly?
>
>> Thanks for AI.
>>
>> It looks we should "goto out" after ksft_test_result_fail().
>
>I'll assume that's a separate patch.
Agree.
The credit belongs to @Dev. Not sure I should send the fix.
--
Wei Yang
Help you, Help me
