On Tue, Jun 09, 2026 at 08:41:25PM +0200, David Hildenbrand (Arm) wrote: > On 6/9/26 18:15, Breno Leitao wrote: > > On Tue, Jun 09, 2026 at 04:41:01PM +0200, David Hildenbrand (Arm) wrote:
> >> a) HWPoisonKernelOwned: this is not the common style for us to name > >> functions. > >> > >> is_kernel_owned_page() or sth like that would do. > > > > Ack, I will rename it is_kernel_owned_page() > > > > In my defence, most of the functions similar to HWPoisonKernelOwned() > > has this name format, and I got this discussion earlier (with Lance? > > I think). Here are the similar function names in that file: > > > > * HWPoisonHandlable > > * PageHWPoisonTakenOff() > > * SetPageHWPoisonTakenOff > > Some of these probably date back to our old way of handling page flags and > things, like PageLRU. > > But we really should stop :) Ack! > > I will update in the new version. > > Thanks! Probably best to wait a bit, the merge window is coming up either way, > so this will have to wait a bit either way. no hurry at all, Thanks for the review, --breno
