On Wed, 15 Jul 2026 14:28:59 +0200
Alessio Faina <[email protected]> wrote:

> In case iproute2 is older than version 5.14.0, released ~Sept 1, 2021,
> the End.DT46 support is not available and the host_vpn_tests test contained
> in the srv6_end_dt46_l3vpn_test.sh file is failing in some kernel backports.
> This is the result of those tests:
>
> ################################################################################
> TEST SECTION: SRv6 VPN connectivity test among hosts in the same tenant
> ################################################################################
>
>     TEST: IPv6 Hosts connectivity: hs-t100-1 -> hs-t100-2 (tenant 100)  [ 
> FAIL ]
>
>     TEST: IPv4 Hosts connectivity: hs-t100-1 -> hs-t100-2 (tenant 100)  [ 
> FAIL ]
>
>     TEST: IPv6 Hosts connectivity: hs-t100-2 -> hs-t100-1 (tenant 100)  [ 
> FAIL ]
>
>     TEST: IPv4 Hosts connectivity: hs-t100-2 -> hs-t100-1 (tenant 100)  [ 
> FAIL ]
>
>     TEST: IPv6 Hosts connectivity: hs-t200-3 -> hs-t200-4 (tenant 200)  [ 
> FAIL ]
>
>     TEST: IPv4 Hosts connectivity: hs-t200-3 -> hs-t200-4 (tenant 200)  [ 
> FAIL ]
>
>     TEST: IPv6 Hosts connectivity: hs-t200-4 -> hs-t200-3 (tenant 200)  [ 
> FAIL ]
>
>     TEST: IPv4 Hosts connectivity: hs-t200-4 -> hs-t200-3 (tenant 200)  [ 
> FAIL ]
>
> To amend this, check the current running iproute2 supports the required
> feature and, if not, just skip the entire test to avoid a failure.
>
> Signed-off-by: Alessio Faina <[email protected]>
> ---
> v3:
>  -  fix indentation in test_iproute2_supp_or_ksft_skip()
>  -  fix subject to reflect full test suite skip
>  -  
> https://lore.kernel.org/netdev/[email protected]/
> v2:
>     - skip entire test suite if iproute2 is too old
> v1: 
> https://lore.kernel.org/netdev/[email protected]/
>
>  .../testing/selftests/net/srv6_end_dt46_l3vpn_test.sh  | 10 ++++++++++
>  1 file changed, 10 insertions(+)

Hi Alessio,

Thanks for the v3, both points are addressed.

About the check flagged by Sashiko: "ip route add help" is fine.
iproute2 catches the "help" word and prints the usage before it parses it as a
prefix, so the grep works.
As a small nit, the other srv6 selftests use "ip route help" without "add".
This is not blocking, and I don't think it is worth spinning a v4 just to
remove the "add".

Reviewed-by: Andrea Mayer <[email protected]>

Ciao
Andrea

Reply via email to