On Mon, 27 Jul 2026 01:25:08 -0300 Marcelo Mendes Spessoto Junior wrote:
> +#define INIT_SIN6_LOOPBACK(name)                                     \
> +     struct sockaddr_in6 name = {                                    \
> +             .sin6_family    = AF_INET6,                             \
> +             .sin6_addr      = IN6ADDR_LOOPBACK_INIT,                \
> +             .sin6_port      = htons(8888),                          \
> +     }

Please avoid magic macros

> @@ -183,6 +239,21 @@ static void run_tests(int fd)
>               expect_fail(flowlabel_get(fd, 5, IPV6_FL_S_ANY, 
> IPV6_FL_F_CREATE));
>       }
>  
> +     explain("Prepare TCP SYN for REMOTE flag validation");
> +     int remote_listener = tcp_listen();
> +     int remote_cfd, remote_afd;

and don't declare variables half way thru the function
C coding style applies

Reply via email to