On Mon, Aug 31, 2026 at 09:37:33AM -0700, Jakub Kicinski wrote: > gro.py runs its full set of cases three times over - against SW GRO, > HW GRO and LRO. It's our test with the longest runtime. The 318 cases > take 12m30s on mlx5 with a debug kernel. > > Bumping the timeout for all tests feels wrong when we can so easily > split the GRO test by execution mode. Shorter runtime also helps retry > just the failing portion / mode (we retry failing tests to try to > detect flakes vs real failures). > > Move the main logic to gro_lib.py and add one program per mode - > gro_sw.py, gro_hw.py and gro_lro.py, 102 cases each. Move PPPoE to > a dedicated test. It has been tacked onto the tests in an ugly way, > and it only runs against SW GRO anyway. > > Note that unfortunately this will case a rename of all test cases. > The mode moves from the case name to the test name > > gro.py test.sw_ipv4_data_same > > becomes > > gro_sw.py test.ipv4_data_same > > Signed-off-by: Jakub Kicinski <[email protected]> > --- > We also saw 20min runs on gve, but those may have been errors. > The GVE runner is very flaky and even when it runs it doesn't seem > to execute the gro test. Perhaps because the test times out? > --- > tools/testing/selftests/drivers/net/Makefile | 9 ++- > tools/testing/selftests/drivers/net/gro_hw.py | 14 ++++ > .../drivers/net/{gro.py => gro_lib.py} | 68 +++++++++---------- > .../testing/selftests/drivers/net/gro_lro.py | 15 ++++ > tools/testing/selftests/drivers/net/gro_sw.py | 14 ++++ > .../selftests/drivers/net/pppoe_gro.py | 46 +++++++++++++ > .../selftests/net/lib/ksft_setup_loopback.sh | 2 +- > 7 files changed, 129 insertions(+), 39 deletions(-) > create mode 100755 tools/testing/selftests/drivers/net/gro_hw.py > rename tools/testing/selftests/drivers/net/{gro.py => gro_lib.py} (92%) > mode change 100755 => 100644 > create mode 100755 tools/testing/selftests/drivers/net/gro_lro.py > create mode 100755 tools/testing/selftests/drivers/net/gro_sw.py > create mode 100755 tools/testing/selftests/drivers/net/pppoe_gro.py >
Reviewed-by: Joe Damato <[email protected]>
