Hi, On Sat, 10 Oct 2026 17:49:52 +0000, [email protected] wrote: > [Severity: Medium] > If cli.py is present but can't run, should that be a skip instead of a > failure?
I don't think so. Running net selftests from a source tree already needs the ynl CLI and its dependencies: double_udp_encap.sh calls it without any check, and the Python tests import the same library. A CLI that is present but fails points to a broken setup, so failing is correct. The file check only covers the installed layout, where cli.py is not shipped. > [Severity: Medium] > Does this block change which code path the chk_gro "aggregation with TSO > off" check below it tests? Yes. A kprobe on __veth_napi_enable_range confirms that the NAPI is now enabled from veth_set_features() instead of veth_open(). The series is already applied, so I will fix it in a follow-up for net-next, together with the selftest requested in [1]. It will end the block with GRO enabled while the device is down. [1] https://lore.kernel.org/all/[email protected]/ Cheers, Tianyi
