On Wed, 21 Oct 2026, NeilBrown wrote:
> > +   d_drop(entry);
> > +   res = d_splice_alias(inode, entry);
>
> As of f1ac607f786f d_splice_alias() handles hashed dentries
> and the d_drop() is not needed and not wanted.

Thanks. I'll rebase onto 7.4-rc1 (will make note of the dependency), which
has the commit f1ac607f786f.

> > -   d_instantiate(entry, inode);
> > +   if (d_in_lookup(entry))
> > +           d_splice_alias(inode, entry);
> > +   else
> > +           d_instantiate(entry, inode);
>
> Similar to above, d_splice_alias() is now sufficient for all cases.

Thanks, fuse_create_open() also handles FUSE_TMPFILE, which needs
d_instantiate() for its dentry to stay unhashed. Otherwise I can have it use
d_splice_alias().

Reply via email to