On Wed, Feb 26, 2014 at 12:30 AM, Uwe Kleine-König <[email protected]> wrote: > Hello, > > On Wed, Feb 26, 2014 at 02:14:49PM +0900, Jingoo Han wrote: >> diff --git a/drivers/leds/leds-clevo-mail.c b/drivers/leds/leds-clevo-mail.c >> index d93e245..5974810 100644 >> --- a/drivers/leds/leds-clevo-mail.c >> +++ b/drivers/leds/leds-clevo-mail.c >> @@ -19,7 +19,7 @@ MODULE_AUTHOR("Márton Németh <[email protected]>"); >> MODULE_DESCRIPTION("Clevo mail LED driver"); >> MODULE_LICENSE("GPL"); >> >> -static bool __initdata nodetect; >> +static bool nodetect __initdata; >> module_param_named(nodetect, nodetect, bool, 0); >> MODULE_PARM_DESC(nodetect, "Skip DMI hardware detection"); > not sure why I'm on Cc, but yes, the change is in line with gcc docs. > But I wonder if __initdata is ok for a variable backing a module > parameter as it appears in /sys. Does > > cat /sys/module/leds-clevo-mail/parameters/nodetect > > result in an oops? If yes, better drop the __initdata instead of moving > it.
Agree with Uwe, I think we'd better drop it. It is not right for a module parameter. And please update a previous similar patch as well. Thanks, -Bryan -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
