On Sun, Sep 28, 2014 at 1:57 AM, Xiubo Li <[email protected]> wrote: > If the inlcude headers aren't sorted alphabetically, then the > logical choice is to append new ones, however that creates a > lot of potential for conflicts or duplicates because every change > will then add new includes in the same location. >
Good move, thanks. I will merge it. -Bryan > Signed-off-by: Xiubo Li <[email protected]> > --- > drivers/leds/leds-gpio-register.c | 2 +- > drivers/leds/leds-gpio.c | 10 +++++----- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/leds/leds-gpio-register.c > b/drivers/leds/leds-gpio-register.c > index 1c4ed55..fbd8934 100644 > --- a/drivers/leds/leds-gpio-register.c > +++ b/drivers/leds/leds-gpio-register.c > @@ -7,9 +7,9 @@ > * Free Software Foundation. > */ > #include <linux/err.h> > +#include <linux/leds.h> > #include <linux/platform_device.h> > #include <linux/slab.h> > -#include <linux/leds.h> > > /** > * gpio_led_register_device - register a gpio-led device > diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c > index 57ff20f..1b1e617 100644 > --- a/drivers/leds/leds-gpio.c > +++ b/drivers/leds/leds-gpio.c > @@ -10,17 +10,17 @@ > * published by the Free Software Foundation. > * > */ > -#include <linux/kernel.h> > -#include <linux/platform_device.h> > +#include <linux/err.h> > #include <linux/gpio.h> > +#include <linux/kernel.h> > #include <linux/leds.h> > +#include <linux/module.h> > #include <linux/of.h> > -#include <linux/of_platform.h> > #include <linux/of_gpio.h> > +#include <linux/of_platform.h> > +#include <linux/platform_device.h> > #include <linux/slab.h> > #include <linux/workqueue.h> > -#include <linux/module.h> > -#include <linux/err.h> > > struct gpio_led_data { > struct led_classdev cdev; > -- > 2.1.0.27.g96db324 > -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
