On Wed, Jan 14, 2015 at 5:51 AM, Geert Uytterhoeven <[email protected]> wrote: > of_find_node_by_name() calls of_node_put() on its "from" parameter. > To counter this, mc13xxx_led_probe_dt() calls of_node_get() first. > > Use of_get_child_by_name() instead to get rid of the refcount hack. > > Signed-off-by: Geert Uytterhoeven <[email protected]> > Cc: [email protected]
Looks good, applied to my tree. Thanks, -Bryan > --- > Compile-tested only > --- > drivers/leds/leds-mc13783.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c > index 85c3714e1b5aabba..e2b847fe22a1c934 100644 > --- a/drivers/leds/leds-mc13783.c > +++ b/drivers/leds/leds-mc13783.c > @@ -134,9 +134,7 @@ static struct mc13xxx_leds_platform_data __init > *mc13xxx_led_probe_dt( > if (!pdata) > return ERR_PTR(-ENOMEM); > > - of_node_get(dev->parent->of_node); > - > - parent = of_find_node_by_name(dev->parent->of_node, "leds"); > + parent = of_get_child_by_name(dev->parent->of_node, "leds"); > if (!parent) > goto out_node_put; > > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
