On Fri 2015-07-17 10:46:47, Jacek Anaszewski wrote: > led_set_brightness_sync function was visible only internally to the > LED subsystem. It is now being made publicly available since it has > become apparent that this is a caller who should decide whether > brightness is to be set in a synchronous or an asynchronous way. > The function is modified to use brightness_set op as the second > option if brightness_set_sync is not implemented. Eventually all > LED subsystem drivers will be modfified to set brightness only in > a synchronous way with use of brightness_set op and brightness_set_sync > op will be removed. LED core will take care of calling brightness_set > op asynchronously if needed.
As I explained before, having single brightness_set callback sometimes block and sometimes not based on flag elsewhere is a bad design. > Signed-off-by: Jacek Anaszewski <[email protected]> > Cc: Bryan Wu <[email protected]> > Cc: Andrew Lunn <[email protected]> > Cc: Sakari Ailus <[email protected]> Nacked-by: Pavel Machek <[email protected]> > --- > drivers/leds/leds.h | 13 ------------- > include/linux/leds.h | 29 +++++++++++++++++++++++++++++ > 2 files changed, 29 insertions(+), 13 deletions(-) > > diff --git a/drivers/leds/leds.h b/drivers/leds/leds.h > index bc89d7a..1c026c9 100644 > --- a/drivers/leds/leds.h > +++ b/drivers/leds/leds.h > @@ -26,19 +26,6 @@ static inline void led_set_brightness_async(struct > led_classdev *led_cdev, > led_cdev->brightness_set(led_cdev, value); > } > > -static inline int led_set_brightness_sync(struct led_classdev *led_cdev, > - enum led_brightness value) > -{ > - int ret = 0; > - -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
