> +void led_set_brightness_nosleep(struct led_classdev *led_cdev,
> + enum led_brightness value)
> +{
> + led_cdev->brightness = min(value, led_cdev->max_brightness);
> +
> + if (led_cdev->flags & LED_SUSPENDED)
> + return;
> +
> + /* Use brightness_set op if available, it is guaranteed not to sleep */
> + if (led_cdev->brightness_set)
> + led_cdev->brightness_set(led_cdev, led_cdev->brightness);
> +
> + /* If brightness setting can sleep, delegate it to a work queue task */
> + led_cdev->delayed_set_value = led_cdev->brightness;
> + schedule_work(&led_cdev->set_brightness_work);
> +}
To me, it looks like there is a missing else, or return here. We don't
want both led_cdev->brightness_set() and the work queue.
> +EXPORT_SYMBOL(led_set_brightness_nosleep);
There seems to be a mixture of EXPORT_SYMBOL and
EXPORT_SYMBOL_GPL. Have you figured out the pattern? led-class.c seems
to be all _GPL, but led-core.c has a mixture.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
