Fair enough. I expected some... erm.. "pushback". As I'd rather not fork, I'll look into the faking openprom and see how close it gets me.
Consider the patch revoked. -- Sam On Tue, Apr 03, 2007 at 11:25:22AM -0700, David Miller wrote: > From: Sam Creasey <[EMAIL PROTECTED]> > Date: Tue, 3 Apr 2007 10:32:35 -0400 > > > This patch (re) introduces support for the CG3 driver on Sun3, and for > > BW2 on Sun3x. It applies cleanly to both the m68k CVS tree and the > > vanilla tree. > > > > Signed-off-by: Sam Creasey <[EMAIL PROTECTED]> > > If you guys want to share driver code with the Sparc port, please do > it properly. > > I am not applying a pile of ifdef's that basically duplicate half of > the existing driver. > > What you can do instead is to build a fake openprom device tree and > register those devices with the generic device subsystem, and then the > driver will mostly just work out of the box. It should be easy to > duplicate the arch/sparc64/kernel/prom.c and of_device.c code you > use as well as the driver interfaces in include/asm-sparc64/prom.h > and of_device.h > > This way you don't need to shit all over the drivers adding hardcoded > register addresses and ad-hoc probing code. For special behaviors, > you can add openprom node properties that the driver can test for at > run time to guide behavior, again instead of ifdefs. > > Thanks. - To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
