On Thu, Aug 16, 2007 at 08:16:15AM -0700, Brad Boyer wrote: > On Sun, Aug 12, 2007 at 03:30:12PM +0200, Richard Zidlicky wrote: > > On Sun, Aug 12, 2007 at 11:48:40AM +0200, Geert Uytterhoeven wrote: > > > reveals a serious problem with the Q40 floppy interupt code: > > > > > > | arch/m68k/q40/q40ints.c:215: error: too few arguments to function > > > 'floppy_hardint' > > > > sloppy programming - the 2 args were useless so I wanted to save the > > cycles and stack for pushing them. > > > > Will need to think about a more correct solution for this. > > I would think the "clr.l -(%sp)" that would get generated for each > is not costly enough to be worth the prototype mismatch. I understand > that this is a hot path, but I would think the correctness is more > important. It looks like the implementation does actually use those > arguments, so it would seem unsafe not to set them.
I will to do it correctly now, need also to see if the call from entry.S is correct. Richard - To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
