On Thu, 10 Jan 2008, Stephen R Marenka wrote:
> This patch adds a character device driver to allow user space access to
> the aranym natfeats nfstderr.
A few comments:
- Since you need only one character device, what about using a misc
character device instead?
- Shouldn't nfstderr_init_module() check for the presence of Aranym
natfeatures? Then you can probably drop the test in nfstderr_write()
- Please run scripts/checkpatch.pl on all patches before submission.
BTW, I find it a pity you cannot simply do `echo XXX > /dev/console'
instead...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [EMAIL PROTECTED]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
