Hi,

On Tue, 15 Jan 2008, Geert Uytterhoeven wrote:

> > The speed doesn't seem to be drastically faster (only twice as fast last I 
> > tested with a simple dd). One reason may be that xhdi.cpp opens the file 
> 
> Twice as fast is still better...

I did a quick test and without the open/close sequence, it's again almost 
twice as fast.

> > +int nfhd_getgeo(struct block_device *bdev, struct hd_geometry *geo)
> > +{
> > +   struct nfhd_device *dev = bdev->bd_disk->private_data;
> > +
> > +   geo->cylinders = dev->blocks / (64 >> dev->bshift);
> > +   geo->heads = 4; 
> > +   geo->sectors = 16;
> > +
> > +   return 0;
> > +}
> 
> I don't think you need getgeo these days.

AFAICT it's still the only ioctl that makes the partition offset 
available, it's only really needed for bootloader, but it doesn't hurt 
much either...

> > +static struct block_device_operations nfhd_ops = {
> > +   .owner  = THIS_MODULE,
> > +   .ioctl  = blkdev_ioctl,
> > +   .getgeo = nfhd_getgeo,
> > +};
> 
> Same for ioctl?

Interesting, that explains the stack overflow. :)
(blkdev_ioctl is the main entry function)

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to