On Fri, 10 Oct 2008, Brad Boyer wrote:
> > I have two suggestions. We probably shouldn't be using strcat now that > we aren't trying to append to the existing string. It's probably best to > just switch to strcpy while you're already changing most of them. OK. > Also, there is no such thing as a built-in video on the II,IIx,IIcx,IIfx > type systems. You should either leave it as "Generic NuBus" or change it > to be an error. I disagree. This routine is merely following orders from the bootloader. It doesn't probe anything except nubus. It uses "Generic NuBus" when a nubus card is actually probed. But built-in video cards are not probed at all. Yet the existing code also says "Generic NuBus" (the second instance, that is the one I changed), even though video_is_nubus == 0, i.e. no nubus card was probed. This is bogus. You might argue that it is also bogus to suggest that the bootloader might know something about a generic built-in display on II,IIx,IIcx,IIfx. But the routine presently defers to the bootloader. I didn't change that logic as I don't think it's relevant to the patch, and it means rewriting the routine. Finn > > Brad Boyer > [EMAIL PROTECTED] > > -- > To unsubscribe from this list: send the line "unsubscribe linux-m68k" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
