On Wed, Mar 30, 2011 at 20:41, Geert Uytterhoeven <[email protected]> wrote: > Hi Greg, > > On Wed, Mar 30, 2011 at 09:58, Greg Ungerer <[email protected]> wrote: >> The following set of patches cleans up and merges individual files in >> the arch/m68k/lib directory. Mostly strait forward stuff, >> >> I have build and run tested on ARAnyM/Atari and ColdFire (non-mmu) >> targets.
> Anyway, I did a thorough review, so consider it > Acked-by: Geert Uytterhoeven <[email protected]> Upon actually trying it, I get: arch/m68k/kernel/setup_mm.c:488: undefined reference to `strcpy' arch/m68k/q40/config.c:149: undefined reference to `strcpy' arch/m68k/atari/config.c:582: undefined reference to `strcpy' arch/m68k/atari/config.c:588: undefined reference to `strcpy' arch/m68k/atari/config.c:604: undefined reference to `strcpy' arch/m68k/mac/built-in.o:arch/m68k/mac/config.c:916: more undefined references to `strcpy' follow Some of these are sprintf() or strcat() calls, "optimized" into strcpy() by gcc (4.1.2 20061115 (prerelease) (Ubuntu 4.1.1-21)). Should have thought about that, cfr. commit f9b07897c6288d7e5fc1fd004fccb0c5f1a0e570 ("m68k: Uninline strchr()"). But not all of them: some are real strcpy() calls. Why are they the inline version? Reverting 7a2dc626ba38595bf04c663d834c394e7c0aa1f7 ("m68k: remove no longer used arch/m68k/lib/string.c") fixes this. So we need to keep at least the out-of-line strcpy(). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
