On Wed, Jun 15, 2011 at 4:40 PM, Geert Uytterhoeven <[email protected]> wrote: > On Fri, Jun 10, 2011 at 15:09, Mathias Krause <[email protected]> wrote: >> The address limit is already set in flush_old_exec() so those calls to >> set_fs(USER_DS) are redundant. >> >> Signed-off-by: Mathias Krause <[email protected]> >> Cc: Greg Ungerer <[email protected]> >> --- >> >> Note: I'm not sure about the assignment to current->thread.fs in >> flush_thread() -- shouldn't this be done in set_fs() itself? > > set_fs() is used to temporary set the address space to be used from the > kernel. > current->thread.fs is the address space that will be used when the > thread returns > to userspace. > So I think it's correct. > > For nommu, thread.fs is set, but not really used.
Thanks for the explanation. So only the set_fs() is redundant. Mathias -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
