Hi Greg, Thank you for your suggestion. :) I remove the whole m68knommu conditional in submitted patch.
[REF] http://permalink.gmane.org/gmane.linux.kbuild.devel/8138 Best Regards, Edward On Fri, Apr 27, 2012 at 2:30 PM, Greg Ungerer <[email protected]> wrote: > Hi Edward, > > > On 26/04/12 22:34, Edward Shao wrote: >> >> I have a question about ($(ARCH),m68knommu) check in top of kernel >> Makefile. >> Any reason not to change SRCARCH but change hdr-arch? >> >> If I modify the makefile as below, is it ok? >> >> diff --git a/Makefile b/Makefile >> index afc868e..396ed28 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -228,13 +228,14 @@ ifeq ($(ARCH),tilegx) >> SRCARCH := tile >> endif >> >> -# Where to locate arch specific headers >> -hdr-arch := $(SRCARCH) >> - >> +# Additional ARCH settings for m86k >> ifeq ($(ARCH),m68knommu) >> - hdr-arch := m68k >> + SRCARCH := m68k >> endif >> >> +# Where to locate arch specific headers >> +hdr-arch := $(SRCARCH) >> + >> KCONFIG_CONFIG ?= .config >> export KCONFIG_CONFIG > > > I think it better to just remove the whole m68knommu conditional, > since there is not longer a separate m68knommu arch branch. > > Regards > Greg > > > ------------------------------------------------------------------------ > Greg Ungerer -- Principal Engineer EMAIL: [email protected] > SnapGear Group, McAfee PHONE: +61 7 3435 2888 > 8 Gardner Close FAX: +61 7 3217 5323 > Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
