On Fri, Mar 29, 2013 at 08:56:43AM +0100, Geert Uytterhoeven wrote: > On Fri, Mar 29, 2013 at 12:10 AM, Christian T. Steigies <[email protected]> > wrote: > > The HID drivers seem to be enabled in the official kernel, which runs on > > kullervo, I don't seem to be able to switch off just the microsoft one. > > Maybe by modifying the generic config, but I am afraid the magical package > > building breaks again, genconfig.py does not run on my testing box, not sure > > why. In Geert's tree, memcmp is not used in the driver, thats probably why > > this one builds: > > > > @@ -47,9 +46,9 @@ > > rdesc[559] = 0x45; > > } > > /* the same as above (s/usage/physical/) */ > > - if ((quirks & MS_RDESC_3K) && *rsize == 106 && > > - !memcmp((char []){ 0x19, 0x00, 0x29, 0xff }, > > - &rdesc[94], 4)) { > > + if ((quirks & MS_RDESC_3K) && *rsize == 106 && rdesc[94] == 0x19 && > > + rdesc[95] == 0x00 && rdesc[96] == 0x29 && > > + rdesc[97] == 0xff) { > > rdesc[94] = 0x35; > > rdesc[96] = 0x45; > > } > > > >> >buildds) another way. kernel-package? > > I reported that problem and it got fixed. Probably the fix never made it to > -stable?
Yes, I was not precise. The orig is what hid-microsoft looks like in Debian's linux-source-3.8. The patched one is from Geert's tree, so it is fixed in linux-m68k. Maybe I am missing something, but I don't see anything in the patches at first glance, only this, which makes me shiver: + ret = hid_add_device(hid_dev); + if (ret) + goto probe_err1; Reminds me of fortran, are gotos legal in kernel source? In any case, I can build from Geert's try, but no debian packages (yet). I should try in an unstable chroot, or a real m68k box. Christian -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
