On Mon, 13 Jan 2014, Geert Uytterhoeven wrote: > Hi Finn, > > On Sun, Jan 12, 2014 at 2:56 PM, Finn Thain <[email protected]> > wrote: > > For SCC initialization we cannot assume that the control register is > > in the correct state to accept a register pointer. So first read from > > the control register in order to "sync" up. > > > > Signed-off-by: Finn Thain <[email protected]> > > Thaks for your patch! > > > --- > >
> > This patch fixes a boot failure (presumably caused by unhandled SCC > > interrupt) on PowerBook 180 with CONFIG_EARLY_PRINTK and with the > > bootloader not configured to wake up the serial ports. > > AFAIK this happens only on PowerBooks. Even with this fix, Penguin > > still has to wake the serial ports or else they don't function on > > PowerBooks like this one. > > IMHO the above should be part of the patch description (i.e. above the > three dashes), as it contains valuable information. Is that OK for you? The first part is good information, especially if this were submitted to -stable. The rest, beginning with "AFAIK", is really guesswork based on anecdote (e.g. reports from users not affected). Even the mailing list archives are perhaps too permanent (e.g. the need for the wake-up workaround may go away one day). I'm unsure about submitting this to -stable. I don't like the idea that the first debian user to boot a powerbook might see a crash (depending on bootloader etc). But not all stable trees carry df66834a which is a prerequisite. This patch is only applicable to 3.4.y and >= 3.9.y. Can you nominate particular stable trees? Finn -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
