Hi Geert,

that's certainly correct - the EtherNAT version of the USB driver didn't need the ROM accessors but the version including NetUSBee support does for sure.

Thanks!

Ack'ed-by: Michael Schmitz <[email protected]>

If CONFIG_ATARI_ROM_ISA=n:

drivers/usb/host/isp116x.h: In function ‘isp116x_write_addr’:
drivers/usb/host/isp116x.h:382: error: implicit declaration of function 
‘isa_rom_writew_raw’
drivers/usb/host/isp116x.h: In function ‘isp116x_raw_write_data16’:
drivers/usb/host/isp116x.h:394: error: implicit declaration of function 
‘isa_rom_writew’
drivers/usb/host/isp116x.h: In function ‘isp116x_read_data16’:
drivers/usb/host/isp116x.h:402: error: implicit declaration of function 
‘isa_rom_readw_raw’
drivers/usb/host/isp116x.h: In function ‘isp116x_raw_read_data16’:
drivers/usb/host/isp116x.h:411: error: implicit declaration of function 
‘isa_rom_readw’

The isa_rom_*() calls should depend on CONFIG_ATARI_ROM_ISA instead of
on CONFIG_ATARI.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
To be folded into "m68k/atari: USB - add ISP1160 USB host controller
support"
---
  drivers/usb/host/isp116x.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/isp116x.h b/drivers/usb/host/isp116x.h
index c436f55f2882..634258df159b 100644
--- a/drivers/usb/host/isp116x.h
+++ b/drivers/usb/host/isp116x.h
@@ -355,7 +355,7 @@ struct isp116x_ep {
  #endif
-#ifdef CONFIG_ATARI
+#ifdef CONFIG_ATARI_ROM_ISA
    /*
     * 16 bit data bus byte swapped in hardware on both Atari variants.
     * EtherNAT variant of ISP1160 integration is memory mapped at 0x800000XX,

--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to