Finn, On Tue, Dec 5, 2017 at 7:20 AM, Finn Thain <fth...@telegraphics.com.au> wrote: > This patch brings basic support for the Linux Driver Model to the > NuBus subsystem. > > For flexibility, the matching of boards with drivers is left up to the > drivers. This is also the approach taken by NetBSD. A board may have > many functions, and drivers may have to consider many functional > resources and board resources in order to match a device. > > This implementation does not bind drivers to resources (nor does it bind > many drivers to the same board). Apple's NuBus declaration ROM design > is flexible enough to allow that, but I don't see a need to support it > as we don't use the "slot zero" resources (in the main logic board ROM). > > Eliminate the global nubus_boards linked list by rewriting the procfs > board iterator around bus_for_each_dev(). Hence the nubus device refcount > can be used to determine the lifespan of board objects. > > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Tested-by: Stan Johnson <user...@yahoo.com> > Signed-off-by: Finn Thain <fth...@telegraphics.com.au> > > --- > The conversion of Mac network drivers from the Space.c convention to > the Driver Model takes place in a separate patch series, archived at > https://lkml.org/lkml/2017/11/11/25 > That series motivates parts of this design, such as the definition of > 'for_each_board_func_rsrc'. [] > diff --git a/drivers/nubus/bus.c b/drivers/nubus/bus.c > new file mode 100644 > index 000000000000..b5045e639b4d > --- /dev/null > +++ b/drivers/nubus/bus.c > @@ -0,0 +1,119 @@ > +/* > + * Bus implementation for the NuBus subsystem. > + * > + * Copyright (C) 2017 Finn Thain > + * > + * SPDX-License-Identifier: GPL-2.0 > + */
I think the SPDX id should be on the first line using C++-style // comments. See tglx's doc patches and Linus posts explaining why he wants it this way! -- Cordially Philippe Ombredanne -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
