On Tue, 13 Feb 2018, David Miller wrote: > > I think you have overlooked those modules which offer no way to set > > p->msg_enable, i.e. ax88796, axnet_cs, etherh, hydra, mac8390, > > mcf8390, pcnet_cs and zorro8390. > > Then that's a bug, we have a very simple easy to implement interface for > setting this (ethtool). > > And by adding the simple hook, you will make these older drivers easier > to debug for the few people still using them.
Have you considered that implementing the ethtool hooks in the core driver might allow removal of all 8390 driver 'msg_enable' module parameters and msglevel ethtool hooks added by c45f812f0280, excepting those in the core driver? But even if we did that, it seems to me that we still need this patch. The missing set_msglevel ethtool hooks and the msg_enable bugs patched here are separate issues inasmuchas the lib8390.c module parameter called 'msg_enable' presently controls only the version message whereas the ethtool hooks cannot control the version message logging at all. I'm not against improving ethtool support. Would you please explain how doing so (one way or another) would alter this patch? -- -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html