Tuomas,

Am 06.03.2018 um 04:31 schrieb Tuomas Vainikka:
>>> I think you are talking about esp->regs? For esp->dma_regs, the
>>> ioremap is
>>> conditional on ent->id, but the unmap is not.
>> The details of the ioremap are conditional on the ID, but the fact
>> that the ioremap happens (and hence esp->dma_regs is an ioremapped
>> address) is not. All Zorro-3 boards have to have both their regs and
>> dma_regs remapped.
>>
>> What's confusing is that there is only a single Zorro-3 board
>> currently supported by the driver. Others will be added and I"ll use a
>> switch statement to pick the appropriate address based on the ID. That
>> might make it clearer.
> 
> Fastlane might be the only Z3 SCSI board that has the chip.

Good to know - I've rewritten the probe code to check for the type of
board (Z2 or Z3) based on the ROM data, and make the ioremap/iounmap
conditional on that.

Cheers,

        Michael


> 
> -Tuomas
> 
>>
>>>>>> +}
>>>>>> +
>>>>>> +static void zorro_esp_remove_one(struct zorro_dev *z)
>>>>>> +{
>>>>>> +     struct Scsi_Host *host = zorro_get_drvdata(z);
>>>>>> +     struct esp *esp = shost_priv(host);
>>>>>> +
>>>>>> +     scsi_esp_unregister(esp);
>>>>>> +
>>>>>> +     /* Disable interrupts. Perhaps use disable_irq instead ... */
>>>>>> +
>>>>>> +     free_irq(host->irq, esp);
>>>>>> +     dma_free_coherent(esp->dev, 16,
>>>>>> +                       esp->command_block,
>>>>>> +                       esp->command_block_dma);
>>>>>> +
>>>>>> +     if (host->base > 0xffffff) {
>>>>>> +             iounmap(esp->dma_regs);
>>>>> Do you need to test for ZORRO_PROD_PHASE5_BLIZZARD_1230_IV_1260 first?
>>>> I can't - ent->id is not available here...
>>> Maybe store ent->id in the private struct to get around that?
>> Yes, that could be done. I still think it's not needed.
>>
>> Cheers,
>>
>>    Michael
>>
>>
>>> -- 
>> -- 
>> To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
>> the body of a message to majord...@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to