Hi Greg,

it works as before with dspi driver + MMU.
It builds fine.

Tested-by: Angelo Dureghello <ang...@sysam.it>

On Fri, Apr 20, 2018 at 12:05:48AM +0200, linux-m68k@vger.kernel.org wrote:
> Convert the ColdFire IO access functions to use asm-generic/io.h.
> 
> The motivation for these changes is to fix IO access problems found by
> Angelo Dureghello during his work on ColdFire 5441x when running with
> MMU enabled. It also bought to light problems with ColdFire systems that
> have PCI bus support and their ability to access both the internal
> peripherals and PCI bus peripherals.
> 
> Along with the fixes I improved the ColdFire PCI support so that it works
> with the MMU disabled on the ColdFire 5475. Previously PCI bus support was
> only allowed when building with the MMU enabled. Now you can enable and
> use the PCI bus in any configuration - MMU enabled or disabled.
> 
> These changes force all ColdFire platforms to use the same IO access
> family of functions. The existing code differentiated between systems
> built with MMU enabled and MMU disabled - and there is really no reason
> to do that. Ultimately it does result in the include/asm/io_no.h file
> now being somewhat misnamed. Perhpas I should change that it?
> 
> All in all the changes result in a net removal of ~140 lines, so that is
> a good thing too.
> 
> This version 2 of the patch set drops the bulk addition of iomem() macro
> use to the local read/write calls using constant addresses. That was a
> single huge patch that really needs to be broken up to more managable
> chunks for review. As it was it resulted in a number of new compilation
> warnings (as expected) where address types were not "void __iomem *" clean.
> I'll create a new patch series to deal with that.
> 
> Signed-off-by: Greg Ungerer <gerg@xxxxxxxxxxxxxx>
> ---
>  Kconfig.bus               |    8 -
>  coldfire/pci.c            |  114 --------------
>  include/asm/atarihw.h     |    1
>  include/asm/io.h          |   10 -
>  include/asm/io_mm.h       |  102 +------------
>  include/asm/io_no.h       |  359 
> ++++++++++++++++++++--------------------------
>  include/asm/kmap.h        |   80 ++++++++++
>  include/asm/nubus.h       |    1
>  include/asm/q40_master.h  |    2
>  include/asm/raw_io.h      |   14 -
>  include/asm/vga.h         |    9 +
>  include/asm/virtconvert.h |    2
>  include/asm/zorro.h       |    1
>  mm/kmap.c                 |    8 +
>  14 files changed, 285 insertions(+), 426 deletions(-)
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to