On Mon, Jul 2, 2018 at 10:25 AM Finn Thain <[email protected]> wrote: > > The pmu_init() function has the __init qualifier, but the ops struct > that holds a pointer to it does not. This causes a build warning. > The driver works fine because the pointer is only dereferenced early. > > The function is so small that there's negligible benefit from using > the __init qualifier. Remove it to fix the warning, consistent with > the other ADB drivers.
Would you mind copy/pasting the warning you are seeing. Make sure you have: 58935176ad17 powerpc/via-pmu: Fix section mismatch warning Thanks > Tested-by: Stan Johnson <[email protected]> > Signed-off-by: Finn Thain <[email protected]> > Reviewed-by: Geert Uytterhoeven <[email protected]> > --- > drivers/macintosh/via-pmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c > index 25c1ce811053..f8a2c917201f 100644 > --- a/drivers/macintosh/via-pmu.c > +++ b/drivers/macintosh/via-pmu.c > @@ -378,7 +378,7 @@ static int pmu_probe(void) > return vias == NULL? -ENODEV: 0; > } > > -static int __init pmu_init(void) > +static int pmu_init(void) > { > if (vias == NULL) > return -ENODEV; > -- > 2.16.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
