On Thu, 1 Aug 2019, Michael Schmitz wrote: > >> > >> It's annoying that we can't unconditionally include atarihw.h but I > >> don't have a solution for that. > > The real issue is <asm/amigahw.h> including <asm/raw_io.h>, right? > > > > At first sight, the only reason for that is: > > > > #define atari_readb raw_inb > > #define atari_writeb raw_outb > > > > #define atari_inb_p raw_inb > > #define atari_outb_p raw_outb > > > > Note that the first definition is unused, and the other 3 have only a > > handful > > users. > > > > At second sight, the <asm/raw_io.h> include can just be removed, an Atari > > kernel still builds fine... > > > What is used for raw_inb() and raw_outb() in that case? > > If it's still in_8() and out_8(), no harm done ... >
The object files I looked at, pata_falcon.o and falconide.o, are unchanged. I think this relies on the fact that linux/io.h includes asm/io.h early on. The latter then includes asm/io_mm.h, which does this: #include <asm/raw_io.h> #include <asm/virtconvert.h> #include <asm/kmap.h> #include <asm-generic/iomap.h> #ifdef CONFIG_ATARI #include <asm/atarihw.h> #endif -- > Cheers, > > Michael
