Hi Niklas,
On Wed, Nov 2, 2016 at 2:22 PM, Niklas Söderlund
<[email protected]> wrote:
> A V4L2 driver for Renesas R-Car MIPI CSI-2 interface. The driver
> supports the rcar-vin driver on R-Car Gen3 SoCs where a separate driver
> is needed to receive CSI-2.
>
> Driver is based on a prototype by Koji Matsuoka in the Renesas BSP.
>
> Signed-off-by: Niklas Söderlund <[email protected]>
Looking at the binding doc only...
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/rcar-csi2.txt
> @@ -0,0 +1,116 @@
> +Renesas R-Car MIPI CSI-2 driver (rcar-csi2)
Bindings are meant to describe hardware, not drivers.
> +-------------------------------------------
> +
> +The rcar-csi2 device provides MIPI CSI-2 capabilities for the Renesas R-Car
> +family of devices. It is to be used in conjunction with the rcar-vin driver
R-Car VIN module?
> +which provides the video input capabilities.
> +
> + - compatible: Must be one or more of the following
> + - "renesas,r8a7795-csi2" for the R8A7795 device.
> + - "renesas,r8a7796-csi2" for the R8A7796 device.
> + - "renesas,rcar-gen3-csi2" for a generic R-Car Gen3 compatible device.
> +
> + When compatible with a generic version nodes must list the
> + SoC-specific version corresponding to the platform first
> + followed by the generic version.
> +
> + - reg: the register base and size for the device registers
> + - interrupts: the interrupt for the device
> + - clocks: Reference to the parent clock
> +
> +The device node should contain two 'port' child nodes according to the
> +bindings defined in Documentation/devicetree/bindings/media/
> +video-interfaces.txt. Port 0 should connect the device that is the vidoe
video
> +source for to the CSI-2 . Port 1 should connect the R-Car VIN devices
> +(rcar-vin) devices which can use the CSI-2 device.
Please drop "(rcar-vin)"
> +
> +- Port 0 - Vidoe source
Video
> + - Reg 0 - sub-node describing the endpoint which are the vidoe source
is the video?
> +
> +- Port 1 - VIN instacnes
> + - Reg 0 - sub-node describing the endpoint which are VIN0
> + - Reg 1 - sub-node describing the endpoint which are VIN1
> + - Reg 2 - sub-node describing the endpoint which are VIN2
> + - Reg 3 - sub-node describing the endpoint which are VIN3
> + - Reg 4 - sub-node describing the endpoint which are VIN4
> + - Reg 5 - sub-node describing the endpoint which are VIN5
> + - Reg 6 - sub-node describing the endpoint which are VIN6
> + - Reg 7 - sub-node describing the endpoint which are VIN7
s/are/in/?
> +
> +Example:
> +
> +/* SoC properties */
> +
> + csi20: csi2@fea80000 {
> + compatible = "renesas,r8a7795-csi2";
> + reg = <0 0xfea80000 0 0x10000>;
> + interrupts = <0 184 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 714>;
> + power-domains = <&cpg>;
Please update the power-domains property to match reality.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
