On 3/26/2017 6:27 AM, Sean Young wrote:
...
>> + status = usb_submit_urb(ir->urb_in, GFP_ATOMIC);
>
> This can be GFP_KERNEL.
>
...
>> + rc_free_device(ir->rc);
>
> That change is wrong and will cause a double free.
>
>> usb_kill_urb(ir->urb_in);
>> usb_free_urb(ir->urb_in);
>> usb_free_coherent(dev, ir->len_in, ir->buf_in, ir->dma_in);
>
> Would you be able to split this into multiple commits please?
>
> Thanks,
> Sean
>
Hi Sean,
Thank you for the quick reply, review, corrections, and suggestions. Please
bear with me since this is my first contribution for Linux. The patch
production submission/review process is entirely new to me at this time.
I'll perform the corrections in the forthcoming replies containing the split
patches:
[PATCH 1/3] [media] mceusb: RX -EPIPE (urb status = -32) lockup failure fix
[PATCH 2/3] [media] mceusb: sporadic RX truncation corruption fix
[PATCH 3/3] [media] mceusb: fix inaccurate debug buffer dumps and
misleading debug messages
Thanks again. ..A Sun
