2017-07-07 Shuah Khan <[email protected]>:
> On 06/16/2017 01:39 AM, Gustavo Padovan wrote:
> > From: Gustavo Padovan <[email protected]>
> >
> > To enable vivid to be used with explicit synchronization we need
> > to mark its queues as ordered.
> >
> > Signed-off-by: Gustavo Padovan <[email protected]>
> > ---
> > drivers/media/platform/vivid/vivid-core.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/media/platform/vivid/vivid-core.c
> > b/drivers/media/platform/vivid/vivid-core.c
> > index 8843170..c7bef90 100644
> > --- a/drivers/media/platform/vivid/vivid-core.c
> > +++ b/drivers/media/platform/vivid/vivid-core.c
> > @@ -1063,6 +1063,7 @@ static int vivid_create_instance(struct
> > platform_device *pdev, int inst)
> > q->type = dev->multiplanar ? V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE
> > :
> > V4L2_BUF_TYPE_VIDEO_CAPTURE;
> > q->io_modes = VB2_MMAP | VB2_USERPTR | VB2_DMABUF | VB2_READ;
> > + q->ordered = 1;
>
> How will the driver ensure ordered buffers? Are there more changes needed
> in this driver?
The driver can't requeue a buffer if it mark itself as ordered. It has
to ensure that.
Gustavo
