On Sun, Mar 18, 2018 at 07:47:57AM -0500, Rob Herring wrote:
> On Fri, Mar 09, 2018 at 10:34:40AM +0100, Geert Uytterhoeven wrote:
> > According to the Devicetree Specification, "ok" is not a valid status.
>
> Correct.
>
> > Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support")
> > Signed-off-by: Geert Uytterhoeven <[email protected]>
> > ---
> > For the checkpatch TODO list?
> > https://www.devicetree.org/
> >
> > Documentation/devicetree/bindings/media/rcar_vin.txt | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt
> > b/Documentation/devicetree/bindings/media/rcar_vin.txt
> > index 68c5c497b7fa5551..a19517e1c669eb35 100644
> > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> > @@ -81,7 +81,7 @@ Board setup example for Gen2 platforms (vin1 composite
> > video input)
> > -------------------------------------------------------------------
> >
> > &i2c2 {
> > - status = "ok";
> > + status = "okay";
>
> However, I prefer that status not be in examples as it applies to any
> node and the SoC/board split is not relevant to binding docs. I'd
> cleaned all these up except for the cases with SoC/board split.
Hi Rob,
I'm a little confused. This example is a board override for
a node (implicitly) defined in the DT of an SoC. Could you clarify
when the status should be omitted?
>
> > pinctrl-0 = <&i2c2_pins>;
> > pinctrl-names = "default";
> >
> > @@ -104,7 +104,7 @@ Board setup example for Gen2 platforms (vin1 composite
> > video input)
> > pinctrl-0 = <&vin1_pins>;
> > pinctrl-names = "default";
> >
> > - status = "ok";
> > + status = "okay";
> >
> > port {
> > #address-cells = <1>;
> > --
> > 2.7.4
> >
>
