Hi Laurent,
On 03/05/18 12:13, Laurent Pinchart wrote:
> Hi Kieran,
<snip>
>>> + } else {
>>> + vsp1_rpf_write(rpf, dlb, VI6_RPF_SRCM_ADDR_Y, mem.addr[0]);
>>> + vsp1_rpf_write(rpf, dlb, VI6_RPF_SRCM_ADDR_C0, mem.addr[1]);
>>> + vsp1_rpf_write(rpf, dlb, VI6_RPF_SRCM_ADDR_C1, mem.addr[2]);
>>> + }
>>> }
>>> +
>>> static void rpf_partition(struct vsp1_entity *entity,
>>> struct vsp1_pipeline *pipe,
>>> struct vsp1_partition *partition,
>>> diff --git a/drivers/media/platform/vsp1/vsp1_rwpf.h
>>> b/drivers/media/platform/vsp1/vsp1_rwpf.h index
>>> 70742ecf766f..8d6e42f27908 100644
>>> --- a/drivers/media/platform/vsp1/vsp1_rwpf.h
>>> +++ b/drivers/media/platform/vsp1/vsp1_rwpf.h
>>> @@ -42,6 +42,7 @@ struct vsp1_rwpf {
>>> struct v4l2_pix_format_mplane format;
>>> const struct vsp1_format_info *fmtinfo;
>>> unsigned int brx_input;
>>> + bool interlaced;
>
> kerneldoc might be nice :-)
There's no existing kerneldoc on struct vsp1_rwpf ?
>>>
>>> unsigned int alpha;
>>>
>
> [snip]
>
>>> diff --git a/include/media/vsp1.h b/include/media/vsp1.h
>>> index 678c24de1ac6..c10883f30980 100644
>>> --- a/include/media/vsp1.h
>>> +++ b/include/media/vsp1.h
>>> @@ -50,6 +50,7 @@ int vsp1_du_setup_lif(struct device *dev, unsigned int
>>> pipe_index,>
>>> * @dst: destination rectangle on the display (integer coordinates)
>>> * @alpha: alpha value (0: fully transparent, 255: fully opaque)
>>> * @zpos: Z position of the plane (from 0 to number of planes minus 1)
>>> + * @interlaced: true for interlaced pipelines
>
> Maybe "true if the pipeline outputs an interlaced stream" ?
That's fine - but I've neglected to incorporate this into my v4 repost :-(
If by any magic - v4 is suitable for integration already, and you're happy to
take it into your tree - please feel free to update this comment.
Otherwise it will be in any next update.
--
KB
