Hi Marco,

Thank you for the patch.

On Tuesday, 18 September 2018 16:14:46 EEST Marco Felsch wrote:
> Commit 37c65802e76a ("media: tvp5150: Add sync lock interrupt handling")
> introduced the interrupt handling. But we have to free the
> v4l2_ctrl_handler before we can return the error code.
> 
> Fixes: 37c65802e76a ("media: tvp5150: Add sync lock interrupt handling")
> Signed-off-by: Marco Felsch <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
>  drivers/media/i2c/tvp5150.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
> index 133073518744..40aaa8ca0b63 100644
> --- a/drivers/media/i2c/tvp5150.c
> +++ b/drivers/media/i2c/tvp5150.c
> @@ -1650,7 +1650,7 @@ static int tvp5150_probe(struct i2c_client *c,
>                                               tvp5150_isr, IRQF_TRIGGER_HIGH |
>                                               IRQF_ONESHOT, "tvp5150", core);
>               if (res)
> -                     return res;
> +                     goto err;
>       }
> 
>       res = v4l2_async_register_subdev(sd);

-- 
Regards,

Laurent Pinchart



Reply via email to