Hi Nathan, Thank you for the patch,
On 08/10/18 23:11, Nathan Chancellor wrote: > Clang warns when a variable is assigned to itself. > > drivers/media/i2c/tc358743.c:1921:7: warning: explicitly assigning value > of variable of type 'int' to itself [-Wself-assign] > ret = ret; > ~~~ ^ ~~~ > 1 warning generated. > > Signed-off-by: Nathan Chancellor <[email protected]> Certainly somewhat redundant. Reviewed-by: Kieran Bingham <[email protected]> > --- > drivers/media/i2c/tc358743.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c > index ca5d92942820..41d470d9ca94 100644 > --- a/drivers/media/i2c/tc358743.c > +++ b/drivers/media/i2c/tc358743.c > @@ -1918,7 +1918,6 @@ static int tc358743_probe_of(struct tc358743_state > *state) > ret = v4l2_fwnode_endpoint_alloc_parse(of_fwnode_handle(ep), &endpoint); > if (ret) { > dev_err(dev, "failed to parse endpoint\n"); > - ret = ret; > goto put_node; > } > >
