Hi Nikita,
Thanks for your feedback.
On 2018-11-14 16:10:37 +0300, Nikita Yushchenko wrote:
> > + for (i = 0; i < fd.num_entries; i++) {
> > + struct v4l2_mbus_frame_desc_entry *entry = &fd.entry[i];
> > + int source_pad;
> > +
> > + source_pad = rcsi2_vc_to_pad(entry->bus.csi2.channel);
> > + if (source_pad < 0) {
> > + dev_err(priv->dev, "Virtual Channel out of range: %u\n",
> > + entry->bus.csi2.channel);
> > + return -ENOSPC;
>
> Why -ENOSPC here?
>
> AFAIU negative source_pad here means driver internal error (frame desc
> returned from rcsi2_get_remote_frame_desc() is invalid). Then I think
> error return should be -EIO.
Wops, I agree with you this should not be -ENOSPC. Looking at the code
this seems I just reused the same error code as if there is no space in
the routes array check above this chunk, my bad. I will fix this for the
next version.
--
Regards,
Niklas Söderlund
