On 12/15/18 12:51 PM, Dafna Hirschfeld wrote:
> In the function fwht_encode_frame, 'encoding = encode_plane'
> should be replaced with 'encoding |= encode_plane'
> so existing flags won't be overwrriten.
Good catch.
Hmm, it looks like you didn't update the alignment of the arguments.
I expect checkpatch to complain about it. Can you post a v2 fixing that?
Regards,
Hans
>
> Signed-off-by: Dafna Hirschfeld <[email protected]>
> ---
> drivers/media/platform/vicodec/codec-fwht.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/vicodec/codec-fwht.c
> b/drivers/media/platform/vicodec/codec-fwht.c
> index 5630f1dc45e6..a678a716580c 100644
> --- a/drivers/media/platform/vicodec/codec-fwht.c
> +++ b/drivers/media/platform/vicodec/codec-fwht.c
> @@ -787,7 +787,7 @@ u32 fwht_encode_frame(struct fwht_raw_frame *frm,
>
> if (frm->components_num == 4) {
> rlco_max = rlco + size / 2 - 256;
> - encoding = encode_plane(frm->alpha, ref_frm->alpha, &rlco,
> + encoding |= encode_plane(frm->alpha, ref_frm->alpha, &rlco,
> rlco_max, cf, frm->height, frm->width,
> frm->luma_alpha_step,
> is_intra, next_is_intra);
>
