Hi Arun,
Thank you for the patch.
On Wednesday 16 April 2014 18:29:21 Arun Kumar K wrote:
> From: Pawel Osciak <[email protected]>
>
> This event indicates that the decoder has reached a point in the stream,
> at which the resolution changes. The userspace is expected to provide a new
> set of CAPTURE buffers for the new format before decoding can continue.
>
> Signed-off-by: Pawel Osciak <[email protected]>
> Signed-off-by: Arun Kumar K <[email protected]>
> ---
> .../DocBook/media/v4l/vidioc-subscribe-event.xml | 8 ++++++++
> include/uapi/linux/videodev2.h | 1 +
> 2 files changed, 9 insertions(+)
>
> diff --git a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml index
> 5c70b61..d848628 100644
> --- a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> +++ b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> @@ -155,6 +155,14 @@
> </entry>
> </row>
> <row>
> + <entry><constant>V4L2_EVENT_RESOLUTION_CHANGE</constant></entry>
> + <entry>5</entry>
> + <entry>This event is triggered when a resolution change is detected
> + during runtime by the video decoder. Application may need to
> + reinitialize buffers before proceeding further.
> + </entry>
> + </row>
Would it make sense to report the new resolution in the event data ? I suppose
it might not be available in all cases though. If we can't report it, would it
make sense to document how applications should proceed to retrieve it ?
A similar resolution change event might be useful on subdevs, in which case we
would need to add a pad number to the event data. We could possibly leave that
for later, but it would be worth considering the problem already.
> + <row>
> <entry><constant>V4L2_EVENT_PRIVATE_START</constant></entry>
> <entry>0x08000000</entry>
> <entry>Base event number for driver-private events.</entry>
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 6ae7bbe..58488b7 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -1733,6 +1733,7 @@ struct v4l2_streamparm {
> #define V4L2_EVENT_EOS 2
> #define V4L2_EVENT_CTRL 3
> #define V4L2_EVENT_FRAME_SYNC 4
> +#define V4L2_EVENT_RESOLUTION_CHANGE 5
> #define V4L2_EVENT_PRIVATE_START 0x08000000
>
> /* Payload for V4L2_EVENT_VSYNC */
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
