Hi Lars,
On 06/15/2016 09:05 AM, Lars-Peter Clausen wrote:
> On 06/15/2016 12:49 AM, Steve Longerbeam wrote:
>> + usleep_range(5000, 5001);
> That's kind of not how usleep_range() (the emphasis is on range) is supposed
> to be used. You typically dont care too much about the upper limit here so
> something like maybe 10000 is more appropriate.
Good point, I fixed this as well as all other instances of
usleep_range() in the patch set.
>
>> +static int adv7180_of_parse(struct adv7180_state *state)
>> +{
>> + struct i2c_client *client = state->client;
>> + struct device_node *np = client->dev.of_node;
>> + int ret;
>> +
>> + ret = of_get_named_gpio(np, "pwdn-gpio", 0);
>> +
>> + if (gpio_is_valid(ret)) {
>> + state->pwdn_gpio = ret;
>> + ret = devm_gpio_request_one(&client->dev,
>> + state->pwdn_gpio,
>> + GPIOF_OUT_INIT_HIGH,
>> + "adv7180_pwdn");
>
> This should use the new GPIO descriptor API. That will also make the code
> devicetree independent. Otherwise patch looks OK.
Thanks for the heads-up. I converted to gpiod here, and in all other
patches in the set that were using the deprecated API. Also took the
time to review the active low/high flags in the device tree, and made
sure they are correct and are using the explicit flags GPIO_ACTIVE_*.
The changes are in a new branch mx6-media-staging-v2.1 in my fork
on github ([email protected]:slongerbeam/mediatree.git).
Retested on SabreSD and SabreAuto, still working as before.
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
