On Sun, 22 Feb 2009 23:32:36 -0500 CityK <ci...@rogers.com> wrote: > Mauro Carvalho Chehab wrote: > > On Sun, 22 Feb 2009 15:04:13 -0500 CityK <ci...@rogers.com> wrote: > >> I don't think the Patchwork tool picked it up, as I don't see it in the > >> queue :( > >> http://patchwork.kernel.org/project/linux-media/list/ > >> > >> I'm wondering it the quotations in the subject line are enough to throw > >> the script off. Mauro, any ideas? > >> > > > > In general those tools to pick and work with scripts don't like very much > > inlined patches, although it generally works. > > > > Also, it requires that the patch is not line wrapped. > > > > In this specific case, the patch is line-wrapped: > > > > --- > > v4l-dvb-359d95e1d541-vanilla/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h > > 2009-02-18 > > 13:49:37.000000000 +0100 > > +++ v4l-dvb-359d95e1d541/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h > > 2009-02-18 > > 23:45:43.000000000 +0100 > > > > instead of: > > > > --- > > v4l-dvb-359d95e1d541-vanilla/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h > > 2009-02-18 13:49:37.000000000 +0100 > > +++ v4l-dvb-359d95e1d541/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h > > 2009-02-18 23:45:43.000000000 +0100 > > > > > > So, it doesn't apply as a patch and patchwork discards it. > > Ahh, thanks for the explanation. Its strange that they are not tailored > for inline patches, given that that is precisely the preferred and > prescribed submission method!
Ops! I mean the opposite. It is fine for inlined patch. mime patches may have troubles. In fact, patchwork supports mime types, provided that the emailer describe the attachment with the proper type (text/x-patch). It the mime is text/plain, it should work also. However, if the emailer sends it with a different type, the attachment will be discarded. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
