On Wed, May 13, 2009 at 2:52 AM, Trent Piepho <xy...@speakeasy.org> wrote:
> On Wed, 13 May 2009, Oliver Endriss wrote:
>> 02/05: dvb-ttpci: Check transport error indicator flag
>> http://endr...@linuxtv.org/hg/~endriss/v4l-dvb?cmd=changeset;node=8a742338523d
>
> Are you sure this is a good idea?  The cx88 driver doesn't do this.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

I agree with Trent on this one - dropping the packet at the hardware
level is a bad idea.  If the demodulator is incapable of setting the
TEI bit (which most do) and you are forced to rely on the TSERR line,
then you should be marking the TEI bit and passing the packet on.
Dropping the packet at the hardware level is likely to cause confusion
for app developers (why am I only getting 60% of the expected
packets?)

Like I said above though, in most cases I've seen the demod does all
the work and there is no need to act on the TSERR line at all.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to