Hi, Am Dienstag, den 15.09.2009, 00:55 -0400 schrieb Michael Krufky: > On Tue, Sep 15, 2009 at 12:43 AM, hermann pitton > <hermann-pit...@arcor.de> wrote: > > > > Am Dienstag, den 15.09.2009, 00:18 -0400 schrieb Michael Krufky: > >> On Tue, Sep 15, 2009 at 12:07 AM, Dmitri Belimov <d.beli...@gmail.com> > >> wrote: > >> > On Mon, 14 Sep 2009 08:55:22 -0400 > >> > Michael Krufky <mkru...@kernellabs.com> wrote: > >> > > >> >> On Thu, Sep 10, 2009 at 1:25 AM, Dmitri Belimov <d.beli...@gmail.com> > >> >> wrote: > >> >> > Hi All > >> >> > > >> >> > This is my next patch. > >> >> > > >> >> > Changes: > >> >> > 1. By default charge pump is ON > >> >> > 2. For radio mode charge pump set to OFF > >> >> > 3. Set correct AGC value in radio mode > >> >> > 4. Add control gain of AGC. > >> >> > 5. New function simple_get_tv_gain and simple_set_tv_gain for > >> >> > read/write gain of AGC. 6. Add some code for control gain from > >> >> > saa7134 part. By default this control is OFF 7. When TV card can > >> >> > manipulate this control, enable it. > >> >> > > >> >> > Main changes is control value of AGC TOP in .initdata = > >> >> > tua603x_agc112 array. Use this value for set AGC TOP after set freq > >> >> > of TV. > >> >> > > >> >> > I don't understand how to correct call new function for read/write > >> >> > value of AGC TOP. > >> >> > > >> >> > What you think about it?? > >> >> > > >> >> > >> >> [patch snipped] > >> >> > >> >> > > >> >> > > >> >> > With my best regards, Dmitry. > >> >> > >> >> Dmitry, > >> >> > >> >> The direct usage of .initdata and .sleepdata is probably unnecessary > >> >> here -- If you trace how the tuner-simple driver works, you'll find > >> >> that simply having these fields defined will cause these bytes to be > >> >> written at the appropriate moment. > >> >> > >> >> However, for the actual sake of setting this gain value, I'm not sure > >> >> that initdata / sleep data is the right place for it either. (I know > >> >> that I recommended something like this at first, but at the time I > >> >> didn't realize that there is a range of six acceptable values for this > >> >> field) > >> >> > >> >> What I would still like to understand is: Who will be changing this > >> >> value? I see that you've added a control to the saa7134 driver -- is > >> >> this to be manipulated from userspace? > >> > > >> > Yes > >> > > >> >> Under what conditions will somebody want to change this value? > >> > > >> > for SECAM with strong signal we have wide white crap on the screen. > >> > Need reduce value of AGC TOP. > >> > > >> > For weak signal need increase value of AGC TOP > >> > Ajust value of AGC TOP can get more better image quality. > >> > > >> >> How will users know that they need to alter this gain value? > >> > > >> > By default use value from .initdata > >> > v4l2-ctl can modify this value or via some plugins for TV wach programm. > >> > > >> > End-user programm for watch TV IMHO now is very poor. > >> > > >> > With my best regards, Dmitry. > >> > > >> > >> I have to admit that I am not familiar enough with SECAM myself to see > >> this kind of trouble. For NTSC and PAL, tvtime is a great application > >> -- the only shortcoming that bothers me about tvtime is lack of audio > >> support. One must rely on a separate mechanism to hear audio, whether > >> it's a patch cable from the tv tuner to the sound board, or a separate > >> application decoding DMA audio. ...but that is not what this email > >> thread is about. > >> > >> As far as simple tuning and analog television viewing goes, tvtime > >> rocks. Is it really that difficult for SECAM users? > >> > >> In summary, you are telling us that we need to add userspace controls > >> to handle gain control, for tuning SECAM. I am going to have to ask > >> for help on this topic from those cc'd on this email. (Adding Hans > >> Verkuil, as I value his opinion for controls and dealing with video > >> standards in high regard) > >> > >> Personally, I don't quite understand why we would need to add such > >> controls NOW, while we've supported this video standard for years > >> already. I am not arguing against this in any way, but I dont feel > >> like I'm qualified to accept this addition without hearing the > >> opinions of others first. > >> > >> Can somebody help to shed some light? > >> > >> Cheers, > >> > >> Mike > > > > Mike, > > > > i did discuss this with Dmitri a lot on the list previously. > > > > I destroyed one of my FM1216ME/I MK3 tuners, searched all websites in > > China, to convince him not to do that for the original Philips tuners. > > > > Andy was also pretty active on it, thanks for your help. > > > > However, it is for now only about that TCL MK3, using different filters > > than the original Philips stuff, and their labs have clear results, that > > they can improve SECAM-DK this way for their users. > > Thanks for the comment, Hermann. > > Do you think there is any way that we can automate this without having > to expose an additional user control? > > If you believe that it's necessary, I am fine with adding this, but I > will need Mauro to agree on it as well -- that's why I'm asking for > some argument points.
We can automate this. Just ignore Chinese tuners ... Don't forget, Hauppauge is still leading on that. Likely we support hundreds already, since main chips are the same and they have to fight on the discrets to get some cent out per device. > Some questions that he might ask -- why do we need this in the saa7134 > driver but not the other drivers? Is this specific to this TCL MK3 > only? Could doing this help to improve SECAM support for users of > other tuners? I don't fear Mauro's questions ;), but those not aware off, including me. Simple answer. I'm not on any SECAM-DK and can't tell _at all_. Cheers, Hermann -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
