Hi Laurent,
On Mon, Sep 5, 2016 at 5:43 PM, Laurent Pinchart
<[email protected]> wrote:
>> + for (n = 0; n < 6; n++)
>
> Nitpicking, the driver uses pre-increment in for loops (++n), not post-
> increment. This used to be a best-practice rule in C++, where pre-increment
> can be faster for non-native types (see
> http://antonym.org/2008/05/stl-iterators-and-performance.html for instance).
> I'm not sure if that's still
> relevant, but I've taken the habit of using the pre-increment operator in for
> loops, and that's what the rest of this driver does. This comment applies to
> all other locations in this file.
<surprised>
Didn't know we used C++ and operator overloading in the kernel...
</surprised>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
