The driver used integers for what boolean would have been a better fit.
Use boolean instead.

Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
---
 drivers/media/i2c/ad5820.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c
index d7ad5c1..a9382d1 100644
--- a/drivers/media/i2c/ad5820.c
+++ b/drivers/media/i2c/ad5820.c
@@ -58,7 +58,7 @@ struct ad5820_device {
        struct mutex power_lock;
        int power_count;
 
-       unsigned int standby : 1;
+       bool standby;
 };
 
 static int ad5820_write(struct ad5820_device *coil, u16 data)
@@ -108,7 +108,7 @@ static int ad5820_update_hw(struct ad5820_device *coil)
 /*
  * Power handling
  */
-static int ad5820_power_off(struct ad5820_device *coil, int standby)
+static int ad5820_power_off(struct ad5820_device *coil, bool standby)
 {
        int ret = 0, ret2;
 
@@ -117,7 +117,7 @@ static int ad5820_power_off(struct ad5820_device *coil, int 
standby)
         * (single power line control for both coil and sensor).
         */
        if (standby) {
-               coil->standby = 1;
+               coil->standby = true;
                ret = ad5820_update_hw(coil);
        }
 
@@ -127,7 +127,7 @@ static int ad5820_power_off(struct ad5820_device *coil, int 
standby)
        return ret2;
 }
 
-static int ad5820_power_on(struct ad5820_device *coil, int restore)
+static int ad5820_power_on(struct ad5820_device *coil, bool restore)
 {
        int ret;
 
@@ -137,7 +137,7 @@ static int ad5820_power_on(struct ad5820_device *coil, int 
restore)
 
        if (restore) {
                /* Restore the hardware settings. */
-               coil->standby = 0;
+               coil->standby = false;
                ret = ad5820_update_hw(coil);
                if (ret)
                        goto fail;
@@ -145,7 +145,7 @@ static int ad5820_power_on(struct ad5820_device *coil, int 
restore)
        return 0;
 
 fail:
-       coil->standby = 1;
+       coil->standby = true;
        regulator_disable(coil->vana);
 
        return ret;
@@ -227,7 +227,8 @@ ad5820_set_power(struct v4l2_subdev *subdev, int on)
         * update the power state.
         */
        if (coil->power_count == !on) {
-               ret = on ? ad5820_power_on(coil, 1) : ad5820_power_off(coil, 1);
+               ret = on ? ad5820_power_on(coil, true) :
+                       ad5820_power_off(coil, false);
                if (ret < 0)
                        goto done;
        }
@@ -279,7 +280,7 @@ static int ad5820_suspend(struct device *dev)
        if (!coil->power_count)
                return 0;
 
-       return ad5820_power_off(coil, 0);
+       return ad5820_power_off(coil, false);
 }
 
 static int ad5820_resume(struct device *dev)
@@ -291,7 +292,7 @@ static int ad5820_resume(struct device *dev)
        if (!coil->power_count)
                return 0;
 
-       return ad5820_power_on(coil, 1);
+       return ad5820_power_on(coil, true);
 }
 
 #else
-- 
2.7.4


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to