Hi Niklas,
Thank you for the review.
On Wednesday 14 Sep 2016 20:23:18 Niklas Söderlund wrote:
> On 2016-09-14 02:16:55 +0300, Laurent Pinchart wrote:
> > The subdev userspace API isn't serialized in the core, serialize access
> > to formats and selection rectangles in the driver.
> >
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+rene...@ideasonboard.com>
> > ---
> >
> > drivers/media/platform/vsp1/vsp1_bru.c | 28 +++++++++++++++-----
> > drivers/media/platform/vsp1/vsp1_clu.c | 15 ++++++++---
> > drivers/media/platform/vsp1/vsp1_entity.c | 22 +++++++++++++---
> > drivers/media/platform/vsp1/vsp1_entity.h | 4 ++-
> > drivers/media/platform/vsp1/vsp1_hsit.c | 15 ++++++++---
> > drivers/media/platform/vsp1/vsp1_lif.c | 15 ++++++++---
> > drivers/media/platform/vsp1/vsp1_lut.c | 15 ++++++++---
> > drivers/media/platform/vsp1/vsp1_rwpf.c | 44 +++++++++++++++++++-------
> > drivers/media/platform/vsp1/vsp1_sru.c | 26 +++++++++++++-----
> > drivers/media/platform/vsp1/vsp1_uds.c | 26 +++++++++++++-----
> > 10 files changed, 161 insertions(+), 49 deletions(-)
> >
> > diff --git a/drivers/media/platform/vsp1/vsp1_bru.c
> > b/drivers/media/platform/vsp1/vsp1_bru.c index 8268b87727a7..26b9e2282a41
> > 100644
> > --- a/drivers/media/platform/vsp1/vsp1_bru.c
> > +++ b/drivers/media/platform/vsp1/vsp1_bru.c
> > @@ -142,10 +142,15 @@ static int bru_set_format(struct v4l2_subdev
> > *subdev,
> >
> > struct vsp1_bru *bru = to_bru(subdev);
> > struct v4l2_subdev_pad_config *config;
> > struct v4l2_mbus_framefmt *format;
> >
> > + int ret = 0;
> > +
> > + mutex_lock(&bru->entity.lock);
> >
> > config = vsp1_entity_get_pad_config(&bru->entity, cfg, fmt->which);
> >
> > - if (!config)
> > - return -EINVAL;
> > + if (!config) {
> > + goto done;
> > + ret = -EINVAL;
>
> This looks funny to me, you probably intended to do that in the other
> order right?
Oops, good catch !
> If you fix this feel free to add my:
>
> Acked-by: Niklas Söderlund <niklas.soderl...@ragnatech.se>
Fixed and applied your ack (with +renesas as mentioned in your other email).
> > + }
> >
> > bru_try_format(bru, config, fmt->pad, &fmt->format);
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
