From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Wed, 12 Oct 2016 10:22:47 +0200

The script "checkpatch.pl" pointed information out like the following.

WARNING: Possible unnecessary 'out of memory' message

Thus remove such a logging statement in two functions.

Link: 
http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
 drivers/media/platform/davinci/vpfe_capture.c | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/drivers/media/platform/davinci/vpfe_capture.c 
b/drivers/media/platform/davinci/vpfe_capture.c
index 5c1b8cf..23142f0 100644
--- a/drivers/media/platform/davinci/vpfe_capture.c
+++ b/drivers/media/platform/davinci/vpfe_capture.c
@@ -512,11 +512,9 @@ static int vpfe_open(struct file *file)
 
        /* Allocate memory for the file handle object */
        fh = kmalloc(sizeof(struct vpfe_fh), GFP_KERNEL);
-       if (NULL == fh) {
-               v4l2_err(&vpfe_dev->v4l2_dev,
-                       "unable to allocate memory for file handle object\n");
+       if (!fh)
                return -ENOMEM;
-       }
+
        /* store pointer to fh in private_data member of file */
        file->private_data = fh;
        fh->vpfe_dev = vpfe_dev;
@@ -1853,11 +1851,8 @@ static int vpfe_probe(struct platform_device *pdev)
 
        /* Allocate memory for ccdc configuration */
        ccdc_cfg = kmalloc(sizeof(struct ccdc_config), GFP_KERNEL);
-       if (NULL == ccdc_cfg) {
-               v4l2_err(pdev->dev.driver,
-                        "Memory allocation failed for ccdc_cfg\n");
+       if (!ccdc_cfg)
                goto probe_free_dev_mem;
-       }
 
        mutex_lock(&ccdc_lock);
 
@@ -1944,8 +1939,6 @@ static int vpfe_probe(struct platform_device *pdev)
                                     sizeof(*vpfe_dev->sd),
                                     GFP_KERNEL);
        if (NULL == vpfe_dev->sd) {
-               v4l2_err(&vpfe_dev->v4l2_dev,
-                       "unable to allocate memory for subdevice pointers\n");
                ret = -ENOMEM;
                goto probe_out_video_unregister;
        }
-- 
2.10.1

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to