Hi Andrey,

On Monday 17 Oct 2016 20:39:45 Andrey Utkin wrote:
> On Mon, Oct 17, 2016 at 04:45:06PM +0300, Laurent Pinchart wrote:
> > If you really want to perform such a change, let's not make lines
> > unnecessarily long either. You should add a line break after the first and
> > 
> > second argument:
> >             dprintk(ctx->dev,
> >             
> >                     "%s data will not fit into plane(%lu < %lu)\n",
> >                     __func__, vb2_plane_size(vb, 0),
> >                     (long)q_data->sizeimage);
> > 
> > And everything will fit in 80 columns.
> Same happens in other places, e.g. the hunk for
> cx8802_unregister_driver() in another patch in this series, and not just
> one time (looked just patches where I was a direct recipient).
> There is a printing function call with previously split string literal,
> followed by several arguments. This unnecessarily long function call is
> now a single line.
> Maybe the remaining manual work may be outsourced to seekers of janitor
> tasks?

I'm fine with that, but we should rework the original patches, not merge fixes 
on top of them.


Laurent Pinchart

To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to