On Tue, 2017-05-30 at 18:49 +0900, Hirokazu Honda wrote:
> Some debug output whose log level is set 1 flooded the log.
> Their log level is lowered to find the important log easily.
Maybe use pr_debug instead?
Perhaps it would be better to change the level to a bitmap
so these can be more individually controlled.
Maybe add MODULE_PARM_DESC too.
Perhaps something like below (without the pr_debug conversion)
---
drivers/media/v4l2-core/videobuf2-core.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/media/v4l2-core/videobuf2-core.c
b/drivers/media/v4l2-core/videobuf2-core.c
index 94afbbf92807..88ae2b238115 100644
--- a/drivers/media/v4l2-core/videobuf2-core.c
+++ b/drivers/media/v4l2-core/videobuf2-core.c
@@ -31,12 +31,13 @@
static int debug;
module_param(debug, int, 0644);
+MODULE_PARM_DESC(debug, "debugging output control bitmap (values from 0-31)")
-#define dprintk(level, fmt, arg...) \
- do { \
- if (debug >= level) \
- pr_info("vb2-core: %s: " fmt, __func__, ## arg); \
- } while (0)
+#define dprintk(level, fmt, ...) \
+do { \
+ if (debug & BIT(level)) \
+ pr_info("vb2-core: %s: " fmt, __func__, ##__VA_ARGS__); \
+} while (0)
#ifdef CONFIG_VIDEO_ADV_DEBUG
