Am Wed, 31 May 2017 08:30:34 -0400 schrieb Abylay Ospan <aos...@netup.ru>:
Hi Abylay, > I have ack'ed all patches related to cxd2841er. Please check am i > missing something ? Thank you very much for your review and your ACKs, and in general taking time to look into them! You didn't miss any of the patches :) Will add your ACKs to the cxd2841er patches in a very likely upcoming V2 of the series. > I see some good flags (CXD2841ER_NO_WAIT_LOCK and > CXD2841ER_EARLY_TUNE). I should check it for our boards too :) Re EARLY_TUNE - I wasn't sure if the order of tuner/demod setup is of importance on your devices. When picking the IF freq from the tuner though, we first need to tune and then set up the demod since the demod queries the tuner about this. If your hardware also works with the "earlier tune", maybe we should drop this flag/condition and just move the tune call up. Re NO_WAIT_LOCK - works fine with or without this. However, when e.g. using TVH and looking at the stats, the Web UI will freeze if a retune occurs. Again, not sure if it's absolutely required on your hardware/software - if not, I suggest to remove the flag together with the wait lock entirely. Looking forward for your results and opinions! :-) Best regards, Daniel Scheller
